CTI resurrection Phase 4 companions: factor-graph runtime fixes#90
Merged
Conversation
…cti_workspace#1) Fixes surfaced by validating the full autocti_workspace against the library: - VisualizerDataset1D/VisualizerImagingCI.visualize_combined accept autofit's quick_update kwarg (the AnalysisFactor dispatch forwards it) and zip the per-factor instance list with the analyses instead of broadcasting it; region_list_from receives instance[0] (the shared CTI model). - Result gains analysis_unwrapped: factor-graph child results carry an AnalysisFactor whose __getattr__ forwards to the prior model, so max_log_likelihood_fit and clocker unwrap it (the same unwrap autofit performs when dispatching combined visualization). - plot_utils.fpr_mask_from tolerates layouts without serial prescan/overscan regions (datasets trimmed via apply_settings), and the data_binned plotter guard also catches autoarray ArrayException for trimmed shapes. - The *_list subplot functions raise a clear ValueError on empty input (previously ZeroDivisionError). - ImagingCI threads check_noise_map through to aa.Imaging; the aggregator loader passes check_noise_map=False (masked noise maps). test_autocti: 271 passed, 0 skipped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to the autocti_workspace Phase 4 update (autocti_workspace#1; epic phases 0-3: #83/#85/#87/#89). Validating all 118 workspace scripts end-to-end surfaced eight runtime gaps in the Phase 1/2 rewrites, all on the multi-dataset factor-graph path or trimmed-dataset visualization. All fixed and covered by the existing suite: 271 passed, 0 skipped.
API Changes
VisualizerDataset1D/VisualizerImagingCIvisualize_combined(...)acceptquick_updateand consume per-factor instance lists correctly.ac.Result.analysis_unwrapped(new): unwrapsAnalysisFactoron factor-graph child results;max_log_likelihood_fit/clockernow work onresult_list[i].ImagingCI(..., check_noise_map=...)(new kwarg, default True) threads toaa.Imaging; aggregator loading usescheck_noise_map=False.fpr_mask_fromhandles layouts lacking serial prescan/overscan;*_listplot functions raiseValueErroron empty lists.Test Plan
pytest test_autocti— 271 passedGenerated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code