fix: mark test-mode bypassed fits complete so they are resumable (#1387)#1388
Merged
Conversation
_fit_bypass_test_mode returned without paths.completed(), unlike start_resume_fit — so a bypassed fit was never seen as complete and a rerun re-bypassed the whole pipeline instead of taking result_via_completed_fit. Found by the SLaM resume profiler (autolens_profiling#70), which carried a runtime stopgap; defeats the resume-representative purpose of PYAUTO_TEST_MODE_SAMPLES (#1378/#1381). Fixes #1387. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fit_bypass_test_mode(PYAUTO_TEST_MODE=2/3) wrote samples/summary/results but returned withoutself.paths.completed(), so bypassed fits were never seen as complete and reruns re-bypassed every stage instead of resuming. One-line fix mirroringstart_resume_fit, found via autolens_profiling#70 (the profiler carried a runtime stopgap, to be removed when the profiling repo's current claim frees).API Changes
None — behavioural fix only: a bypassed fit now leaves a
.completedmarker (zipped with the output), making test-mode pipelines resumable like production ones.Test Plan
TestBypassWritesCompleted: the marker lands in the output zip; a secondfit()with a poisonedstart_resume_fitroutes through the completed path.test_autofit/suite: 1497 passed / 1 skipped.Closes #1387.
🤖 Generated with Claude Code