Skip to content

fix: COOLEST interop rejects relative file paths#615

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/coolest-standard-support
Jul 17, 2026
Merged

fix: COOLEST interop rejects relative file paths#615
Jammy2211 merged 1 commit into
mainfrom
feature/coolest-standard-support

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

Follow-up fix to #613 (issue #612): the coolest package's JSONSerializer raises ValueError: Path to JSON file must be an absolute path when to_coolest / from_coolest receive a relative file_path. Both now absolutize the path (the existing tests all used absolute tmp_path, which masked this). Found running the new workspace guide from a relative working directory.

API Changes

None — behaviour fix only (relative paths now work instead of raising).

Test Plan

  • New regression test test__round_trip__relative_file_path (chdir + relative path, both directions).
  • test_autolens/interop/ — 5 passed.

Generated by the PyAutoLabs agent workflow.

The coolest JSONSerializer rejects relative paths; to_coolest/from_coolest
now absolutize file_path. Found running the workspace guide from a relative
cwd; regression test added (monkeypatch.chdir).

Part of #612.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Jammy2211 Jammy2211 added the pending-release PR queued for the next release build label Jul 17, 2026
@Jammy2211
Jammy2211 merged commit 5c3228a into main Jul 17, 2026
5 checks passed
@Jammy2211
Jammy2211 deleted the feature/coolest-standard-support branch July 17, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-release PR queued for the next release build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant