refactor: use paths.preserve_in_zip for the positions cache (#1389 phase 2)#620
Merged
Conversation
Switches the resume fast-path cache write to the public AbstractPaths.preserve_in_zip (PyAutoFit#1390) and drops the private cross-import from autogalaxy (phase 2 of PyAutoFit#1389). Behaviour identical; the test stub gains the no-op method. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of PyAutoFit#1389 (autolens leg): the resume fast-path positions cache now calls the public
AbstractPaths.preserve_in_zip(PyAutoFit#1390, merged) and the private cross-import of_append_to_search_zipfrom autogalaxy is removed. Behaviour identical — validated end-to-end via theautolens_profilingpipeline_resumerecipe (cold 159s → resume ~11–13s).API Changes
None.
Test Plan
test_result.pyfile green (stub gains the no-op method)test_autolens/suite greenUpstream PR
Merge the companion PyAutoGalaxy PR first (it deletes the helper this leg stops importing — merging this one first is also safe, but keep the pair ordered with #1389's checklist).
🤖 Generated with Claude Code