fix: --check-version gates on API-surface hash, not version stamp#16
Merged
Conversation
The session-start drift-check exact-matched each module's __version__ against the wheel-derived baseline. Since PyAutoConf#119 / PyAutoBuild#121 releases no longer commit the stamp back to library main, so a SOURCE checkout reports a frozen stamp while the baseline is wheel-derived — a structurally-permanent false positive (independent of release cadence) that the API-surface hash already proves spurious (public surface byte-identical). Drop the version-equality gate; gate on the public-API-surface hash only (the signal that actually protects the skills/wiki). Versions are still shown for context. Adds test_check_version.py (stack-free via monkeypatched compute_baseline). PyAutoMind build-chain #155 Phase 4 task 3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vx4gezFDNdXP39Q8WzqnTA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The session-start drift-check exact-matched each module's
__version__against the wheel-derived baseline. Since PyAutoConf#119 / PyAutoBuild#121 a release no longer commits the stamp back to librarymain, so a source checkout reports a frozen stamp while the baseline is wheel-derived — a structurally-permanent false positive (independent of release cadence) that the API-surface hash already proves spurious.Mirrors the autolens_assistant fix (build-chain #155 Phase 4 task 3) into this clone, which carried the identical code.
What
Drop the version-equality gate in
check_version(); gate on the public-API-surface hash only. Versions still shown for context. Addstest_check_version.py(stack-free) and updatesskills/af_audit_skill_apis.md.Testing
test_check_version.py— 3 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vx4gezFDNdXP39Q8WzqnTA
Generated by Claude Code