fix: run notebook smoke from the workspace root so dataset paths resolve#101
Merged
Merged
Conversation
`jupyter nbconvert --execute` runs the kernel in the notebook's own directory (e.g. `notebooks/overview/`), so a notebook that resolves repo-root-relative paths — reading `dataset/...` or invoking `scripts/simulators/simulators.py` via the auto-simulate fallback (matching the workspace "run from the repo root" convention and the script smoke's `cwd=WORKSPACE`) — fails from the notebook's subdirectory. Stage a temporary copy of the notebook at the workspace root before executing so the kernel's working directory is the root. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ciVftxvYpefh59wSkR7jN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The notebook smoke fails because
jupyter nbconvert --executeruns the kernel in the notebook's own directory (e.g.notebooks/overview/), not the workspace root. Notebooks resolve repo-root-relative paths — readingdataset/example_1d/...and, via the auto-simulate fallback, invokingscripts/simulators/simulators.py— matching the workspace "run from the repo root" convention and the script smoke'scwd=WORKSPACE. From the notebook's subdirectory those paths don't resolve, so the notebook fails.This is a recent regression (nbconvert now runs the kernel in the notebook's directory) affecting every workspace whose notebooks read committed datasets; it is unrelated to any library change.
Fix
.github/scripts/run_smoke.py: stage a temporary copy of the notebook at the workspace root before executing, so the kernel's working directory is the root and root-relative paths resolve. Verified locally that in-place execution fails while root-staged execution reads the dataset.🤖 Generated with Claude Code
https://claude.ai/code/session_013ciVftxvYpefh59wSkR7jN
Generated by Claude Code