smoke profile: own PYAUTO_SKIP_WORKSPACE_VERSION_CHECK (step 3)#54
Merged
Conversation
Paired with PyAutoBuild's base-env PYAUTO_ scrub: the mega-run injects this var ambiently and the smoke profile was silent on it, so once the scrub strips the ambient PYAUTO_ family the injection would be lost and every mega-run smoke script would fail WorkspaceVersionMismatchError. Making the profile own it keeps the mega-run byte-identical while closing the ambient-leak surface. The release profile already sets it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired with PyAutoBuild#161 step 3 (base-env scrub). Adds
PYAUTO_SKIP_WORKSPACE_VERSION_CHECK: "1"to this workspace's smoke profile (config/build/env_vars.yaml).Why: the mega-run (
PyAutoHeart workspace-validation.yml) injects that var at the jobenv:level, and the smoke profile was silent on it. Once PyAutoBuild's resolver scrubs the ambientPYAUTO_*family, an ambient-only injection would be dropped and every mega-run smoke script would failWorkspaceVersionMismatchError. Making the profile own the var keeps the mega-run byte-identical (proven: 65/65 scripts unchanged) while closing the ambient-leak surface.The release profile already sets this var; this brings the smoke profile in line.
Test Plan
feature/env-scrubbed-baselinebranch, so it runs against the scrub) is the end-to-end check.Generated by the PyAutoLabs agent workflow.