fix: stop clobbering working tfp-nightly in smoke installer (JAX Matern/delaunay_mge)#138
Merged
Merged
Conversation
The smoke installer ran `pip install tensorflow-probability==0.25.0` after `PyAutoArray[optional]`, overwriting the working `tfp-nightly` (which PyAutoArray[optional] pins) with the stable release. Stable tfp crashes at import under the resolved modern JAX — it references `jax.interpreters.xla.pytype_aval_mappings`, removed from JAX >=0.10 — which broke the JAX Matern-kernel (`delaunay_mge`) likelihood path. Remove the line and document why; the JAX path now imports the compatible tfp-nightly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ciVftxvYpefh59wSkR7jN
`jupyter nbconvert --execute` runs the kernel in the notebook's own directory
(e.g. `notebooks/interferometer/`), so a notebook that reads a committed dataset
via a repo-root-relative path (`Path("dataset", ...)`, matching the workspace
"run from the repo root" convention and the script smoke's `cwd=WORKSPACE`)
fails with FileNotFoundError. Stage a temporary copy of the notebook at the
workspace root before executing so the kernel's working directory is the root.
This fixes the `interferometer/simulator.ipynb` and `imaging/modeling.ipynb`
notebook smoke failures (missing `dataset/interferometer/uv_wavelengths/sma.fits`).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013ciVftxvYpefh59wSkR7jN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The JAX Matern-kernel (
delaunay_mge) likelihood path fails at import with:Root cause
.github/scripts/smoke_install.shranpip install tensorflow-probability==0.25.0afterPyAutoArray[optional], overwriting the working pinnedtfp-nightly==0.26.0.dev20260713(which provides the modified-Besselbessel_kve) with the stable release. Stable tfp crashes at import under modern JAX (jax.interpreters.xla.pytype_aval_mappingswas removed in JAX ≥ 0.10), as documented inPyAutoArray/pyproject.toml.Fix
Remove the clobbering line and document why; the JAX path now imports the compatible
tfp-nightlyprovided byPyAutoArray[optional].🤖 Generated with Claude Code
https://claude.ai/code/session_013ciVftxvYpefh59wSkR7jN
Generated by Claude Code