fix: un-park pixelization/MGE scripts (stale NEEDS_FIX, now green)#141
Merged
Conversation
The imaging/data_preparation/manual/mask_irregular script now runs green on clean main (PASSED 8.6s via the build's own execute_script runner). The 2026-04-10 'silent failure' was Convolver.from_gaussian API drift, since fixed by the PyAutoArray convolver consolidation (#360/#361). Folded into this task per the mask_irregular_silent_failure prompt (all 4 imaging repos, one root cause). autogalaxy_workspace + HowToGalaxy handled here; autolens_workspace + HowToLens ride slam-adapt-inversion-cascade (#300). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The LinAlgError 'matrix not positive definite' (pixelization) and 'matrix singular' (MGE) markers were fixed the same day they were filed by the PyAutoArray GaussianKernel PD-guarantee (f1817af0) and never removed. Verified all three scripts run green end-to-end in the build-sweep mode (PYAUTO_TEST_MODE=2, real data), plus a 40-draw numpy inversion A/B across the full LogUniform prior (0 raises, 0 non-finite). Removes 3 stale NEEDS_FIX markers; unrelated markers left intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
Folded in (concurrent session): a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 3 stale
NEEDS_FIXmarkers fromconfig/build/no_run.yaml. TheLinAlgError: matrix not positive definite(pixelization) andmatrix singular(MGE) failures were fixed the same day the markers were filed by the
PyAutoArray GaussianKernel PD-guarantee (
f1817af0— trace-scaled diagonaljitter + symmetrisation on the regularization matrix); the markers were simply
never removed. No source or script changes are needed — this is marker cleanup
with proof the scripts are green.
Verification (reproduce-or-refute):
births the markers (
PYAUTO_TEST_MODE=2, real data,PYAUTO_SMALL_DATASETSunset). The MGE
np.linalg.solveis not behind the sampler, so it isgenuinely exercised.
GaussianKernelLogUniformprior (coefficient/scale 1e-6 -> ~5e5): 0 raises, 0 non-finite on both
cholesky(default) andslogdet.Addresses Heart RED reason
"58 stale parked script(s)"(corrective PR).Scripts Changed
No script edits --
config/build/no_run.yamlonly. Markers removed (scripts now un-parked and verified green):imaging/features/pixelization/modeling-- wasLinAlgError: matrix not positive definiteinterferometer/features/pixelization/modeling-- wasLinAlgError: matrix not positive definiteinterferometer/features/multi_gaussian_expansion/likelihood_function-- wasLinAlgError: matrix singular -> InversionExceptionUnrelated
NEEDS_FIX/SLOWmarkers (imaging/modeling KeyError, shapelets SLOW) left intact.Test Plan
PYAUTO_TEST_MODE=2, real data)Refs #140 (workspace half; HowToGalaxy PR paired).
Generated by the PyAutoLabs agent workflow.