Fix/issue 30 sector config - #191
Open
omari91 wants to merge 6 commits into
Open
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before asking for a review for this PR make sure to complete the following checklist:
Changes proposed in this Pull Request
sectorparameter get overwritten #30 (Configurations ofsectorparameter get overwritten): Changed the initialisation logic inscripts/pypsa-de/build_scenarios.pyto usenot inmembership tests instead of.get(...)truthiness checks for thesector,industry, andsolvingconfig dictionaries. This prevents custom configurations from being completely overwritten and erased when the user passes an empty dictionary or False.Checklist
Required:
Changelog.md. (Please add if needed!)If applicable:
scripts/lib/validation. (N/A)doc/*.rstfiles. (N/A)