-
Notifications
You must be signed in to change notification settings - Fork 55
fix(rps): credit behind-the-meter rooftop solar against RPS targets #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WilsonHM18
wants to merge
9
commits into
PyPSA:develop
Choose a base branch
from
WilsonHM18:fix/rps-btm-rooftop-solar
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
338af99
Merge pull request #726 from PyPSA/develop
trevorb1 3187e50
address doc warnings
trevorb1 fa167c4
add barnes_2026 publication
trevorb1 f38d756
Merge pull request #744 from PyPSA/dr-pub
trevorb1 fe2c829
add recent publications (#772)
trevorb1 eefa3b8
fix(rps): credit behind-the-meter rooftop solar against RPS targets
WilsonHM18 8497c5f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 58b5949
refactor(rps): consolidate EIA fetch into eia module, clarify BTM dem…
WilsonHM18 ebd6e96
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
workflow/repo_data/policy_constraints/small_scale_solar.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| state,year,generation_mwh | ||
| AL,2023,460000 | ||
| AZ,2023,5890000 | ||
| AR,2023,190000 | ||
| CA,2023,39800000 | ||
| CO,2023,2640000 | ||
| CT,2023,1530000 | ||
| DE,2023,390000 | ||
| FL,2023,9620000 | ||
| GA,2023,2180000 | ||
| ID,2023,480000 | ||
| IL,2023,1130000 | ||
| IN,2023,560000 | ||
| IA,2023,290000 | ||
| KS,2023,270000 | ||
| KY,2023,200000 | ||
| LA,2023,460000 | ||
| ME,2023,820000 | ||
| MD,2023,2050000 | ||
| MA,2023,4870000 | ||
| MI,2023,1800000 | ||
| MN,2023,1010000 | ||
| MS,2023,150000 | ||
| MO,2023,470000 | ||
| MT,2023,170000 | ||
| NE,2023,200000 | ||
| NV,2023,2100000 | ||
| NH,2023,680000 | ||
| NJ,2023,4280000 | ||
| NM,2023,700000 | ||
| NY,2023,4550000 | ||
| NC,2023,2060000 | ||
| ND,2023,50000 | ||
| OH,2023,1280000 | ||
| OK,2023,340000 | ||
| OR,2023,1460000 | ||
| PA,2023,1870000 | ||
| RI,2023,520000 | ||
| SC,2023,680000 | ||
| SD,2023,70000 | ||
| TN,2023,480000 | ||
| TX,2023,8700000 | ||
| UT,2023,1090000 | ||
| VT,2023,610000 | ||
| VA,2023,1740000 | ||
| WA,2023,1110000 | ||
| WV,2023,80000 | ||
| WI,2023,760000 | ||
| WY,2023,120000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me (although I haven't tested it)! Im just wondering if this should be a flag option from the config? Like have we checked the different demand sources (EFS, AEO, etc) to ensure rooftop solar isn't accounted for in their projections? If we have, we should ensure that is clear. to the user. Else, just changing this to an optional flag would be good, I think? Or I may just be misunderstanding the implementation! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging this. I just added a docstring note clarifying the assumption. Do you know whether EFS and AEO demand profiles in pypsa-usa represent net or gross load? My understanding is that they're all calibrated to metered grid data (net of BTM), which would make the credit appropriate across all demand sources. Happy to add a config flag if you think that's safer given the uncertainty.