Skip to content

dot-rendered images transparent and shadows added#25

Merged
QAMichaelPeng merged 2 commits into
QAMichaelPeng:mainfrom
chadmiller-saq:dark-mode-backgrounds-better
Nov 6, 2024
Merged

dot-rendered images transparent and shadows added#25
QAMichaelPeng merged 2 commits into
QAMichaelPeng:mainfrom
chadmiller-saq:dark-mode-backgrounds-better

Conversation

@chadmiller-saq
Copy link
Copy Markdown
Contributor

@chadmiller-saq chadmiller-saq commented May 20, 2024

Dot used to write opaque white backgrounds. Normally okay until night falls.

Now, write transparent images and invert the image.

Dot used to write opaque white backgrounds. Normally okay until night
falls.

Now, write transparent images.

This sucks because the foreground is still dark.

We instead use CSS drop-shadows to draw a text color around the
alpha edges, thereby making black-on-black, actually
black-over-white-on-black.
@chadmiller-saq
Copy link
Copy Markdown
Contributor Author

Screenshot 2024-05-20 at 09 57 52

Previously

@chadmiller-saq
Copy link
Copy Markdown
Contributor Author

This is going to conflict with #21, but the resolution should be obvious.

@chadmiller-saq
Copy link
Copy Markdown
Contributor Author

Screenshot 2024-11-05 at 20 04 23

@QAMichaelPeng QAMichaelPeng merged commit 9a9726c into QAMichaelPeng:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants