[pull] master from docker:master#158
Merged
Merged
Conversation
This PR makes the Docker daemon start automatically after installation by default, with a --no-autostart opt-out flag. This addresses issue #124 and aligns with the "opinionated convenience" philosophy of get.docker.com. Changes: - Autostart enabled by default (AUTOSTART=1) - Added --no-autostart flag to opt-out - Smart systemd detection using /run/systemd/system directory check - Falls back to traditional service management (service/chkconfig/update-rc.d) - Uses sh_c pattern for proper dry-run support - All informational messages output to stderr The systemd detection checks for /run/systemd/system directory which only exists when systemd is actually running as PID 1. This prevents failures in container environments where systemctl is installed but systemd is not running. Tested across all supported distributions: - Ubuntu (20.04, 22.04, 24.04) - Debian (11, 12) - CentOS Stream (8, 9) - Fedora (40, 41) - RHEL/AlmaLinux (8, 9) Fixes #124 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Gajesh Bhat <gajeshbht@gmail.com>
Automatically start Docker service with --no-autostart disable option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )