refactor(reports): read validation artifacts asynchronously - #62
Merged
phodal merged 1 commit intoAug 4, 2026
Merged
Conversation
Implements asynchronous report-validation reads using docs/specs/2026-08-04-async-report-validation-reads.md. Independent generated artifacts now load concurrently while preserving validation order and staged publication. Validated with the focused HTML checks, the 32-test render suite, 6 documentation-link checks, 8 loopback preview checks, and isolated-cache package verification. The full suite passed 1,145 of 1,148 tests; the remaining three were sandbox-only loopback EPERM failures. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors report validation to read generated artifacts (findings JSON, Markdown report, and optional HTML report) concurrently using node:fs/promises, removing synchronous filesystem reads from the async validation flow while preserving validation behavior and output.
Changes:
- Replace
readFileSyncusage withreadFilefromnode:fs/promisesinrender-report.mjs. - Read findings/Markdown/optional-HTML in a single
Promise.allduring validation. - Add a spec documenting intent, acceptance scenarios, risk note, and test evidence.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/harness-analysis/render-report.mjs | Switches validation artifact loading to concurrent async reads and reuses the loaded HTML text for HTML validation. |
| docs/specs/2026-08-04-async-report-validation-reads.md | Documents the refactor’s intent, ACs (ARV-AC-1..4), plan, and observed test/review evidence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.