Skip to content

fix(clusters): use working S3 URL format for CloudFormation role template link#2807

Open
Guimove wants to merge 1 commit into
stagingfrom
fix/cloudformation-role-template-url-console
Open

fix(clusters): use working S3 URL format for CloudFormation role template link#2807
Guimove wants to merge 1 commit into
stagingfrom
fix/cloudformation-role-template-url-console

Conversation

@Guimove

@Guimove Guimove commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The AWS "Cloudformation stack" quick-launch link in the cluster credentials modal used the legacy path-style S3 URL (https://s3.amazonaws.com/cloudformation-qovery-role-creation/template.json).
  • That URL returns a 301 with no Location header for this bucket (it lives in us-east-2, and the legacy global path-style endpoint is really only well-behaved for us-east-1 buckets). Switched to the virtual-hosted-style URL (https://cloudformation-qovery-role-creation.s3.amazonaws.com/template.json), matching the format already used in our docs, which resolves directly with a 200 OK.

Note: this was initially raised as a possible fix for a customer (Semble) Access Denied report on Quick Create Stack, but we've since confirmed the customer's error is unrelated to this URL format (they got the same result on both URL variants) - it's most likely caused by an SCP or IAM restriction on their AWS account, still under investigation. This PR stands on its own as a minor robustness fix, not a resolution to that customer issue.

Test plan

  • Verified the old URL returns 301 with no Location header via curl
  • Verified the new URL returns 200 OK via curl
  • Manually click "Cloudformation stack" link in the cluster credentials modal and confirm the AWS Quick Create Stack page loads the template without error

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.60%. Comparing base (d1900fd) to head (7dc24f7).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2807      +/-   ##
===========================================
+ Coverage    46.93%   47.60%   +0.66%     
===========================================
  Files         1252      783     -469     
  Lines        26778    19628    -7150     
  Branches      7804     5956    -1848     
===========================================
- Hits         12569     9343    -3226     
+ Misses       12052     8636    -3416     
+ Partials      2157     1649     -508     
Flag Coverage Δ
unittests 47.60% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…late link

The template.json bucket lives in us-east-2. The legacy path-style
global endpoint (s3.amazonaws.com/bucket/key) only resolves without a
redirect for us-east-1 buckets, so CloudFormation's quick-create-stack
page failed to load the template with an Access Denied error. Switch
to the virtual-hosted-style URL already used in the docs, which
resolves directly with no redirect.
@Guimove Guimove force-pushed the fix/cloudformation-role-template-url-console branch from f117e70 to 7dc24f7 Compare July 7, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant