fix(clusters): use working S3 URL format for CloudFormation role template link#2807
Open
Guimove wants to merge 1 commit into
Open
fix(clusters): use working S3 URL format for CloudFormation role template link#2807Guimove wants to merge 1 commit into
Guimove wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #2807 +/- ##
===========================================
+ Coverage 46.93% 47.60% +0.66%
===========================================
Files 1252 783 -469
Lines 26778 19628 -7150
Branches 7804 5956 -1848
===========================================
- Hits 12569 9343 -3226
+ Misses 12052 8636 -3416
+ Partials 2157 1649 -508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…late link The template.json bucket lives in us-east-2. The legacy path-style global endpoint (s3.amazonaws.com/bucket/key) only resolves without a redirect for us-east-1 buckets, so CloudFormation's quick-create-stack page failed to load the template with an Access Denied error. Switch to the virtual-hosted-style URL already used in the docs, which resolves directly with no redirect.
f117e70 to
7dc24f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://s3.amazonaws.com/cloudformation-qovery-role-creation/template.json).301with noLocationheader for this bucket (it lives inus-east-2, and the legacy global path-style endpoint is really only well-behaved forus-east-1buckets). Switched to the virtual-hosted-style URL (https://cloudformation-qovery-role-creation.s3.amazonaws.com/template.json), matching the format already used in our docs, which resolves directly with a200 OK.Note: this was initially raised as a possible fix for a customer (Semble)
Access Deniedreport on Quick Create Stack, but we've since confirmed the customer's error is unrelated to this URL format (they got the same result on both URL variants) - it's most likely caused by an SCP or IAM restriction on their AWS account, still under investigation. This PR stands on its own as a minor robustness fix, not a resolution to that customer issue.Test plan
301with noLocationheader via curl200 OKvia curl