Remove failed-new-file TOC entries before opening sync PR - #289
Open
kp992 wants to merge 2 commits into
Open
Conversation
Author
|
@mmcky Please review the files under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sync run fails to translate a new lecture, the
_toc.ymlwas committed with an entry for the absent file, producing a dangling reference that broke the target build and corrupted cross-references in every sibling lecture.Changes:
sync-orchestrator.ts(filtering logic + exportedremoveTocFileEntries),pr-creator.ts(PR body notice),index.ts(thread new field through). New unit tests cover flat/parts TOC layouts, the existing-file exemption, and the PR body section.Fixes #156