Renumber Job Search VI-X, and point baseurl at the live site - #273
Merged
Conversation
Two independent fixes, bundled because both take effect only at the next publish build and that build is imminent. Job Search renumbering. Upstream inserted Job Search V and shifted five siblings; the shifts were lost with the auto-closed #242 and never arrived by another route. Seeding mccall_risk as V in #264 turned that into an active collision: mccall_risk and mccall_persist_trans both read 工作搜寻 V. Shift the five, matching the English source verbatim — mccall_persist_trans V→VI, career VI→VII, jv VII→VIII, odu VIII→IX, mccall_q IX→X — in each file's H1 and its translation.title, plus the English half of jv's {index} target, which also read VII. References to Job Search I-IV are deliberately untouched: they sit before the insertion point, so the two in-prose cross-references in mccall_persist_trans (III and IV) remain correct. Baseurl. lectures/_config.yml pointed html.baseurl at python.quantecon-zh-cn.org, which is NXDOMAIN and has never been configured as a Pages custom domain. It reached published output only as rel=canonical and og:url, so no reader was affected, but it told search engines that 148 pages live on a host with no DNS record. Point it at the site that actually serves, matching the other five editions. Prose and config only; no code cell changes, so the execution cache is unaffected. Refs #266 (the two refactor backports and the likelihood_bayes state refresh remain open there), #270, and QuantEcon/project-translation#20. Renumbering source: QuantEcon/lecture-python.myst#760 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR bundles two publish-time content fixes for the zh-cn lecture site: (1) renumber the Job Search lecture headings/titles to match the upstream English sequence after the insertion of “Job Search V”, and (2) update the Jupyter Book html.baseurl to the actual live GitHub Pages URL so canonical/OG URLs are correct.
Changes:
- Renumber Job Search lecture
translation.titleand H1 headings from V–IX to VI–X across five affected lectures. - Update the
jvlecture’s{index}heading target to the new numeral so the index entry matches the updated title. - Point
lectures/_config.ymlhtml.baseurltohttps://quantecon.github.io/lecture-python.zh-cn/.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lectures/mccall_persist_trans.md | Update translation.title and H1 to Job Search VI (工作搜寻 VI) |
| lectures/career.md | Update translation.title and H1 to Job Search VII (工作搜寻 VII) |
| lectures/jv.md | Update translation.title and indexed H1 to Job Search VIII (工作搜寻 VIII / Job Search VIII) |
| lectures/odu.md | Update translation.title and H1 to Job Search IX (工作搜寻 IX) |
| lectures/mccall_q.md | Update translation.title and H1 to Job Search X (工作搜寻 X) |
| lectures/_config.yml | Update html.baseurl to the live GitHub Pages site URL |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent fixes, bundled because each takes effect only at the next publish build and that build is imminent — the re-publish that #270 requires. Splitting them would cost a second full CI render for one changed line.
1. Job Search renumbering — refs #266
Upstream inserted Job Search V and shifted five siblings. Those shifts were in the auto-closed #242 and never arrived by another route, so seeding
mccall_riskas V in #264 turned a latent gap into an active collision:mccall_riskandmccall_persist_transboth read 工作搜寻 V, and everything after ran one behind.Each numeral now matches the English source verbatim, checked file by file against
QuantEcon/lecture-python.myst:mccall_persist_transcareerjvodumccall_qEleven lines in five files: each lecture's
#heading and itstranslation.title, plus the English half ofjv's{index}target, which also read VII and would otherwise have left the index entry pointing at the old numeral.Job Search I–IV are deliberately untouched. They sit before the insertion point, so the two in-prose cross-references in
mccall_persist_trans— to 工作搜寻 III and 工作搜寻 IV — are still correct and were left alone. After this change the series reads I through X with no duplicate and no gap; a full-corpus sweep for工作搜寻 <numeral>andJob Search <numeral>confirms it.This is only a partial delivery of #266 (issue deliberately left open), which also carries the two refactor backports (
ak_aiyagarifrom myst#706,harrison_krepsfrom myst#669) and thelikelihood_bayesstate-file refresh. Those touch code cells, so they belong in their own change with its own execution run.2. Baseurl — refs QuantEcon/project-translation#20
lectures/_config.ymlsethtml.baseurltopython.quantecon-zh-cn.org, which is NXDOMAIN;gh api repos/QuantEcon/lecture-python.zh-cn/pagesreturnscname: null, so no custom domain has ever been configured. The site serves fromquantecon.github.io/lecture-python.zh-cn.It reached published output only through two
<head>tags —rel=canonicalandog:url— 296 of them across 148 of the 159 published HTML files. No reader was ever affected: navigation, assets and inter-lecture links are all relative or point at live hosts. What it did was tell every search engine that those 148 pages authoritatively live on a host with no DNS record. The other five editions already point at theirquantecon.github.ioURL; this brings the sixth into line, per the ruling on that issue.The line dates to
387e084, 2025-01-15 — not a regression, just never noticed.Scope and risk
Prose and configuration only. No code cell changes, so the execution cache is untouched and this needs no new cache run to publish correctly — only the HTML rebuild that a publish does anyway.
What this does and does not fix on the live site
The two lectures currently share both a Roman numeral and a chapter number, from unrelated causes. This PR fixes the numeral. The duplicated chapter number
57.is the stale Sphinx environment in #270, fixed by #272. Both must land before the re-publish for those pages to read correctly.🤖 Generated with Claude Code