Stop committing generated qe-version.ts (gitignore it like version.ts) - #90
Merged
Conversation
quantecon/VERSION.yml said qe-v9 while the committed generated file still said qe-v8 — the qe-v9 cut updated the source of truth without regenerating the derived file. Rather than adding a regeneration step to the version-cut checklist, stop tracking the file: every consuming script (build, lint, test) already runs copy:qe-version first, and the package's other generated file, src/version.ts, is already gitignored on exactly this pattern. This also ends the spurious working-tree modification every build produced. Fixes #87. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes the tracked packages/mystmd/src/qe-version.ts file and instead treats it as a generated artifact (matching the existing approach for src/version.ts), eliminating stale committed state and avoiding persistent post-build working-tree dirtiness (Issue #87).
Changes:
- Delete the committed generated file
packages/mystmd/src/qe-version.ts. - Add
src/qe-version.tstopackages/mystmd/.gitignoreso it’s no longer tracked and won’t reappear in commits.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/mystmd/src/qe-version.ts | Removes the committed generated QE version file so it can’t go stale vs quantecon/VERSION.yml. |
| packages/mystmd/.gitignore | Ignores src/qe-version.ts (consistent with src/version.ts) to prevent re-tracking. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 14, 2026
mmcky
added a commit
that referenced
this pull request
Aug 14, 2026
qe_version -> qe-v10; feature 15 (a40f0cb) tagged qe-v10. Tag to be cut on this PR's merge commit per the VERSION.yml procedure, so the tagged tree is self-consistent. qe-v10 = qe-v9 + heading attribute blocks + the qe-version.ts untracking housekeeping (#90, no feature row). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mmcky
added a commit
that referenced
this pull request
Aug 14, 2026
…ta (#91) * chore(quantecon): track PR #89 (heading-attributes) in fork trackers VERSION.yml gains feature 15 (merge_sha a40f0cb, tag null until the next qe-v cut); UPSTREAM-PRS.yml gains a standalone heading-attributes candidate — it completes upstream's inline-attribute mechanism (their jupyter-book#1822) and touches no fork-modified code paths, so the cherry-pick should be clean. Downstream adoption is tracked in QuantEcon/claude-latex-to-myst#160 and needs a qe-v10 tag first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(quantecon): cut qe-v10 metadata (heading-attributes) qe_version -> qe-v10; feature 15 (a40f0cb) tagged qe-v10. Tag to be cut on this PR's merge commit per the VERSION.yml procedure, so the tagged tree is self-consistent. qe-v10 = qe-v9 + heading attribute blocks + the qe-version.ts untracking housekeeping (#90, no feature row). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #87 by taking the issue's second option: stop committing the generated file.
packages/mystmd/src/qe-version.tsis regenerated bycopy:qe-versionon every path that consumes it (build,lint,lint:format,test), and the package already gitignores its other generated file,src/version.ts, on exactly this pattern — committingqe-version.tswas the inconsistency. Untracking it removes the stale-contradiction failure mode permanently (there is no committed copy to go stale) and ends the spuriousgit statusmodification that every build produced.Verified after untracking:
bun run buildinpackages/mystmdregenerates the file andmyst --versionstill reportsv1.10.1 (qe-v9); a checkout without the file builds cleanly sincecopy:qe-versionruns beforetsc.No changeset: nothing published changes — the file is generated at build time either way.
🤖 Generated with Claude Code