Skip to content

Reviews: record where the run-2 bundle went, and the working-directory gap it exposed - #60

Merged
mmcky merged 1 commit into
mainfrom
record-bundle-location
Aug 25, 2026
Merged

Reviews: record where the run-2 bundle went, and the working-directory gap it exposed#60
mmcky merged 1 commit into
mainfrom
record-bundle-location

Conversation

@mmcky

@mmcky mmcky commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Two small corrections to the run-2 record, both from tidying up after the run. Repo-level file only, so no version bump is due.

§9 — the bundle's location is now partly resolved. The record said it sat untracked in .audit/. It has since been moved to ~/work/quantecon/_audits/2026-08-25-quantecon-meta-issues, matching the naming of the existing 2026-07-29-quantecon-meta-issues-reviews entry, after which the meta checkout returned to fully clean — git status empty, HEAD unchanged at 58d577d. That incidentally strengthens the read-only result in §4: the audit left zero residue in the audited repo. Still open is whether the AWS and access-token portions should additionally be filed against QuantEcon/infrastructure.

New follow-up 6 — the working-directory rule needs a definition of "dirty". Its stated goal is that "a run leaves git status clean", and option 3 (outside the checkout) is conditioned on the repo otherwise "showing dirty". But option 2 (.audit/ at the checkout root) leaves an untracked directory, which does appear in git status unless the repo ignores that path. meta has no .gitignore at all, so option 3 was indicated by the rule's own condition and option 2 was taken.

The consequence was real if minor: 2.4 MB of findings, including AWS and access-token material, sat untracked in a public repo checkout until moved by hand. A git add -A there would have staged it. Worth either defining "dirty" as any git status output, or noting that option 2 only satisfies the goal in repos that already ignore the path.

🤖 Generated with Claude Code

…y gap it exposed

The record said the bundle sat untracked in .audit/; it has since been
moved to ~/work/quantecon/_audits/2026-08-25-quantecon-meta-issues,
after which the meta checkout returned to fully clean. §9 now says so,
leaving open only whether the AWS and access-token portions belong
against QuantEcon/infrastructure.

Moving it surfaced a gap worth recording as follow-up 6. The
working-directory rule's goal is that a run leaves git status clean,
and option 3 is conditioned on the repo otherwise showing dirty — but
option 2 leaves an untracked directory, which does show unless the repo
ignores that path. meta has no .gitignore, so option 3 was indicated
and option 2 was taken.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 25, 2026 07:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the run-2 audit record for quantecon-meta-issues to accurately document (1) where the findings bundle was moved after the run, and (2) a newly identified ambiguity in the working-directory rule that allowed untracked audit output to remain in a public checkout.

Changes:

  • Add a new follow-up item clarifying what “dirty” means in the working-directory rule, noting that option 2 (.audit/) can still surface in git status depending on repo ignores.
  • Update the “Where should the bundle live?” section to record that the bundle was moved out of the audited checkout to ~/work/quantecon/_audits/2026-08-25-quantecon-meta-issues, restoring a fully clean checkout.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmcky
mmcky merged commit 75ae7c9 into main Aug 25, 2026
6 checks passed
@mmcky
mmcky deleted the record-bundle-location branch August 25, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants