Drop the translation claim from the dashboard footnote - #250
Merged
Conversation
The footnote said translation traffic is counted under the corresponding English series. That is true for three of the four translations and not the fourth, so as written it is wrong. lecture-python.zh-cn, lecture-python-programming.fa and lecture-python-programming.fr all carry the same measurement ID as their English site, so their readers are counted, inseparably, under the English series. lecture-intro.zh-cn has analytics commented out in lectures/_config.yml and its deployed pages carry no GA tag at all, so its readership is counted nowhere. Rather than qualify a sentence that is incidental to the point of the footnote, it goes. The tagging gap is a real issue and is being tracked separately in QuantEcon/website-dynamic.
✅ Deploy Preview for grand-swan-ca5201 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the QuantEcon analytics dashboard page to remove an inaccurate claim about translation traffic attribution in the sessions footnote, leaving only the verified statement about what “sessions” represent and what series are included.
Changes:
- Removed the sentence asserting translation traffic is counted under the corresponding English series.
- Kept the footnote’s remaining (accurate) description of sessions being visits summed across eight lecture series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction to #249. I asserted something in that footnote that turns out not to be true, and it is live on the public dashboard.
The footnote said translation traffic "is counted under the corresponding English series". That holds for three of the four translations, but not the fourth:
lecture-python.zh-cnG-J0SMYR4SG3, same as python.quantecon.orgpythonlecture-python-programming.faG-X7DH1M2DPY, same as python-programming.quantecon.orgpython-programminglecture-python-programming.frG-X7DH1M2DPY, same as python-programming.quantecon.orgpython-programminglecture-intro.zh-cnlecture-intro.zh-cnhas its analytics block commented out inlectures/_config.yml, and its deployed pages atquantecon.github.io/lecture-intro.zh-cn/carry no GA tag at all. I checked the deployed HTML as well as the config, since the two can diverge.The claim originated in QuantEcon/website-dynamic#10 and I repeated it without verifying — here, and in the pipeline's
properties.yml. Thanks to @mmcky for asking the question that surfaced it.Rather than qualify a sentence that is incidental to what the footnote is for, this removes it. The footnote now reads:
The same correction is going into
properties.ymlin the pipeline repo, and the untagged translation is worth tracking on its own — it is a genuine gap rather than a wording problem.🤖 Generated with Claude Code