-
Notifications
You must be signed in to change notification settings - Fork 3
Add image preprocessing functionality and update seg.py #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
76553c0
b6021f2
dcade71
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| from .image_preprocessors.enhance_clahe import enhance_clahe | ||
| from .image_preprocessors.enhance_gamma import enhance_gamma | ||
|
Comment on lines
+1
to
+2
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this addition is likely used to call from the frontend, but such a connection between the backend and frontend would violate the MVC architecture. I'll look through the frontend PR next but would it be possible to remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the CLAHE settings have been completely replaced by the P high and P low parameters in Yuanshan’s branch (60-3D-Motion-Compensation).
The main issue is that different developments take time, and merging requests also introduces delays. In the meantime, some features from already developed branches may become outdated, conflict with newer changes, or require rework before integration.
Do you think it would be a good idea to keep this PR open until Yuanshan’s PR is also ready?