Conversation
| ) | ||
| # left to middle | ||
| U = ones(scalartype(H), left_virtualspace(H, 1)) | ||
| U = ones(storagetype(H), left_virtualspace(H, 1)) |
There was a problem hiding this comment.
I think here we should actually call removeunit instead of writing this as a contraction. This is both more efficient and avoids having to deal with storagetype altogether.
Let me know if you need help with this though
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
046f4d0 to
44d6fe6
Compare
11674d6 to
d4e1a03
Compare
|
Had to rebase on top of |
|
(just converted to draft to avoid rerunning all the tests for the various rebases) |
Oh good call, thank you! |
Mostly allowing passing an array type instead of just an element type to allow GPU arrays to back MPS tensors