Repository navigation
feat: 405 Method Not Allowed with Allow header (issue #19) - #32
Merged
Merged
Conversation
- Scan routers on route miss; if any method matches the path, respond 405 with ordered Allow and plain body - state::methods_matching_path; response::send_405_method_not_allowed - ASGI tests: POST-only, GET+HEAD, true 404 Closes #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On no match in the current method’s router, if another method’s router would match the same request path, return 405 with an Allow header (canonical method order) and a short
text/plainbody.Tests
GETto POST-only path → 405,Allowincludes POSTPOSTto GET-only path → 405,Allowincludes GET, HEADPOSTto unregistered path → 404Closes #19