Repository navigation
test+docs: Granian RSGI e2e coverage and CI (issue #12) - #36
Merged
Merged
Conversation
- Add subprocess e2e for POST + JSON body via real granian --interface rsgi - Document granian e2e in development.md; comment in ci.yml Closes #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--interface rsgi).docs/development.md: section on Granian RSGI e2e and that it runs in CI..github/workflows/ci.yml: comment that the full pytest run includestest_granian_e2e.py.The GET e2e was already part of CI when
granianis in dev extras; this makes the P0 item explicit and extends coverage.Closes #12