Repository navigation
Pre-route set_middleware hook (CORS preflight) — issue #11 - #37
Merged
Merged
Conversation
Wire AppState.middleware in dispatch: call (scope, protocol) after path/method and before body read; None continues, other values use handler response mapping. Factor send_handler_map for reuse. Document in handlers.md; add ASGI CORS test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
App.set_middleware/AppState::middleware: one optional(scope, protocol)callback that runs after method/path are known, before body read and routing.Noneto continue; any other return value is mapped like a route handler and sent (short-circuit).send_handler_mapshared for middleware and normal handler path.docs/handlers.md; ASGI test: OPTIONS preflight 204, POST handler not invoked.