Repository navigation
feat: add ASGI websocket spike with docs and tests - #67
Merged
Merged
Conversation
Introduce a minimal WebSocket helper and ASGI websocket dispatch path so the optional ASGI entry can handle websocket scopes without touching the RSGI HTTP pipeline.
Allow applications to register exact-path websocket handlers and dispatch them through the ASGI bridge as a practical spike for issue #52.
Add an end-to-end style websocket test for connect, receive, send, and close to validate the new ASGI websocket spike behavior.
Document the new websocket API, its current ASGI-only scope, and the split between Python spike implementation and future Rust/RSGI work.
Add the websocket page to the main documentation index so the new ASGI spike API is discoverable.
Mark websocket support as partial via the ASGI spike and clarify that RSGI-native websocket support is still pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebSockethelper (accept, receive/send, close)@app.websocket("/path")registration and dispatch for exact-path websocket handlers on the ASGI entryTest plan
make testtests/test_websocket_asgi.py::test_asgi_websocket_echo_flowpassesCloses #52