Skip to content

perf(form): eliminate multipart full-body clone #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Apr 27, 2026
Merged

perf(form): eliminate multipart full-body clone #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/dispatch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ pub async fn run_rsgi(
pyo3_async_runtimes::tokio::into_future(aw)
})?;
let body_obj: PyObject = read_fut.await?;
let body_bytes: Vec<u8> = Python::with_gil(|py| -> PyResult<Vec<u8>> {
let mut body_bytes: Vec<u8> = Python::with_gil(|py| -> PyResult<Vec<u8>> {
let b = body_obj.bind(py);
if let Ok(x) = b.extract::<Vec<u8>>() {
return Ok(x);
Expand Down Expand Up @@ -521,7 +521,8 @@ pub async fn run_rsgi(
.await
}
};
let parsed = match form::parse_multipart(body_bytes.clone(), &boundary).await {
let multipart_body = std::mem::take(&mut body_bytes);
let parsed = match form::parse_multipart(multipart_body, &boundary).await {
Ok(p) => p,
Err(e) => {
return response::send_text(
Expand Down
Loading