Skip to content

fix(ui): one control height per toolbar row (ERD, results, SQL header) #1439

Closed

Description

@ZhuchkaTriplesix

Problem

Rows of controls of different sizes sit side by side, which is what #1333 set out to remove:

  • ERD toolbar: the Names / Keys / All strip is dense (28 px) next to md (32 px) buttons and menus.
  • Results toolbar: the Grid / Groupings / Charts strip, icon buttons and the sm export menus are not one height.
  • Sizes are written by hand almost everywhere (QueryaControlScope is used in 3 places).

Scope

  • Wrap each toolbar in a QueryaControlScope and drop the per-control size: / dense: where it only repeats the scope.
  • Replace dense: true on tab strips with size: so they follow the scope.
  • Layout test per migrated toolbar: one height for every control in the row (the pattern of querya_control_row_height_test).

Found while driving a Linux debug build of dev after the button migration (UI consistency review). Part of epic #1331.

Activity

  1. added
    bugSomething isn't working
    frontendTheme parser epic label: frontend
    uiUser interface components and widgets
    uxUser experience, keyboard shortcuts and interactions
    P2Medium priority / Parity & Refactoring
    on Oct 11, 2026
  2. ZhuchkaTriplesix commented on Oct 11, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Done in dev: the ERD, chart and results toolbars set one control size through QueryaControlScope (#1461) and the SQL header row is in an md scope with a height test (#1470).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium priority / Parity & RefactoringbugSomething isn't workingfrontendTheme parser epic label: frontenduiUser interface components and widgetsuxUser experience, keyboard shortcuts and interactions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions