Skip to content

fix(sql): do not discard dirty result-grid edits on Execute #867

Description

@ZhuchkaTriplesix

Summary

SQL Workspace tab-close confirms dirty result-grid edits, but Execute (and a successful re-run) disposes/replaces stagingBuffer with no prompt. Pending cell edits vanish. Same class as Table Browser #771.

Repro

  1. Run a simple SELECT with a PK in the result (Postgres / MySQL / SQLite).
  2. Edit a cell (pending badge).
  3. Press Execute again (same or different query).

Expected: discard dialog, Cancel keeps the buffer. Actual: buffer is disposed; status becomes a new row count.

Scope

  • Gate Execute in postgres_sql_workspace / mysql_sql_workspace / sqlite_sql_workspace with the same discard confirm as tab close (showUnsavedTabChangesDialog or confirmDiscardTableEditsIfDirty).
  • Tests: dirty buffer + Execute does not dispose until confirmed.

Out of scope

  • SQL-grid schema/PK/rowid Save parity (separate issue).
  • Extension Table Browser discard (separate issue).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdata-gridInteractive data grid, cell editor, filtering, groupingsstabilityTheme parser epic label: stabilityuxUser experience, keyboard shortcuts and interactions

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions