perf(shell): prevent workspace LayoutBuilder and layout rebuilds during sidebar toggle (#984) - #1019
Merged
ZhuchkaTriplesix merged 1 commit intoSep 27, 2026
Conversation
…ng sidebar toggle (#984)
ZhuchkaTriplesix
deleted the
issue/984-sidebar-toggle-layout-optimization
branch
September 28, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #984
Summary
Resolves the remaining scope of #984 (following Part 1's #1004
LazyOffstage):_MainContentSplitState, during_widthSpringanimation ticks (toggleSidebarand drag flings),Expandedpreviously computed a new width on each frame (maxWidth - currentW - currentHandleW), forcing fullperformLayoutpasses down the visible workspace and rebuilding activeLayoutBuilderelements (WorkspaceEmptyHero,VirtualResultGrid,DataGridStagingToolbar, etc.) on every single tick (~3.4–4.6ms per frame).ClipRectandOverflowBox(alignment: Alignment.topLeft), holding constraints stable atconstraints.maxWidthwhile animating. Flutter'sRenderObject.layoutearly-exits in O(1) across intermediate frames, eliminating per-frame reflows andLayoutBuilderrebuilds completely.sidebar_toggle_test.dartverifying stable constraints across intermediate ticks for both collapse and expand animations.