feat(ui): desktop popovers for dropdowns and menus (#1021) - #1022
Merged
Merged
Conversation
- QueryaDropdown: compact variant, no ripple, soft shadow, visible keyboard focus - migrate Groupings and Value panel DropdownButton to QueryaDropdown - add QueryaActionMenu; ExportMenuButton no longer uses PopupMenuButton - filter bar suggestions: theme colours, no ink - NoSplash in Material theme; guard test against Material dropdowns
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1021
QueryaDropdown:compactvariant, no ripple, softer shadow, visible keyboard focus on trigger and rowsDropdownButton->QueryaDropdown(compact)QueryaActionMenu;ExportMenuButtonuses it instead ofPopupMenuButtonNoSplashin the Material theme; guard test forbids Material dropdowns inlib/Not done: open-below/flip positioning and type-ahead (still MenuAnchor defaults), golden test for popup visuals,
fontFamilyin the Material theme.Tests:
flutter testpasses,dart analyzeclean.