Skip to content

ui(erd): toolbar surface, Export menu, labelled and titled states (#1157) - #1183

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1157-erd-toolbar-export-states
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1157-erd-toolbar-export-states

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1157

Changes

  • Toolbar on the SQL toolbar surface (SqlEditorChrome.sqlToolbarDecoration).
  • One Export menu (QueryaActionMenu): Mermaid (.mmd), SVG, PNG, Copy Mermaid. The menu is disabled until the schema loads.
  • File names come from the database: <database>-erd.svg, .mmd, .png, falling back to erd. The workspace passes its effective database name.
  • States through shared widgets: QueryaSpinner labelled Loading schema…; a failed load shows QueryaEmptyState with the error and Retry; an empty schema shows a titled QueryaEmptyState.
  • Tests: the export menu items write erd.mmd and erd.svg, the failed load shows its title and Retry.

Not in this PR

🤖 Generated with Claude Code

)

The diagram toolbar uses the SQL toolbar surface. Mermaid, SVG and PNG move into
one Export menu with a copy of the Mermaid text. Files are named
<database>-erd, from the connection's effective database. Loading shows
"Loading schema…", a failed load shows its message with Retry, and an empty
schema shows a titled state, all through the shared QueryaEmptyState and
QueryaSpinner.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets P2 Medium priority / Parity & Refactoring labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 13.21 ms 12.50 ms -5.4%
p90 23.61 ms 22.94 ms -2.8%
p99 48.35 ms 52.87 ms +9.3% ⚠️
stutters 305.00 285.00 -6.6%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit b3d6d6d into dev Oct 9, 2026
14 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1157-erd-toolbar-export-states branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant