Skip to content

perf(sql-workspace): probe the transaction state only when unknown (#1172) - #1191

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1172-transaction-refresh-scope
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1172-transaction-refresh-scope

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1172

Changes

  • After a successful read in autocommit mode, when no transaction is known to be open, the server is not probed again.
  • The cached panes, which show the transaction label, are rebuilt only when the transaction state actually changes. A plain query therefore rebuilds only its own pane.
  • Test: the first query probes once, a second plain read in autocommit does not probe.

Not in this PR

…1172)

After a successful read in autocommit mode, with no transaction known to be
open, the server is not asked again. The cached panes (which show the
transaction label) are rebuilt only when the transaction state actually
changes, so a plain query rebuilds only its own pane.
@github-actions github-actions Bot added editor Code/SQL editor performance Theme parser epic label: performance P2 Medium priority / Parity & Refactoring labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 9.45 ms 10.25 ms +8.5% ⚠️
p90 18.29 ms 19.21 ms +5.0% ⚠️
p99 38.07 ms 39.35 ms +3.4%
stutters 332.00 324.00 -2.4%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 12.60 ms 17.43 ms +38.3% ⚠️
p90 23.50 ms 29.12 ms +23.9% ⚠️
p99 47.99 ms 51.16 ms +6.6% ⚠️
stutters 279.00 284.00 +1.8%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 734d3be into dev Oct 9, 2026
14 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1172-transaction-refresh-scope branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editor Code/SQL editor P2 Medium priority / Parity & Refactoring performance Theme parser epic label: performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant