Skip to content

ui(sql-workspace): Session menu for autocommit, statement timeout, Begin and Preferences (#1150) - #1193

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1150-session-menu
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1150-session-menu

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1150

Changes

  • The autocommit switch, the statement timeout dropdown and the settings button become one Session ▾ menu (QueryaActionMenu). The menu shows the autocommit state and, for the timeout, the current value with a check mark.
  • Menu entries: Autocommit on/off, the timeout values, Begin transaction (while no transaction is open), Preferences. The values and handlers are the ones used before.
  • The transaction badge and the inline Commit / Rollback from the previous change stay as they are.

Not in this PR

  • The one-row layout: the query tab caption and the Data Output bar still exist, Diagram is still in the toolbar, and the results toolbar has no elapsed time.
  • Run group and editor group with icon buttons (History, Format, Open, Save).
  • Widget tests for the menu entries and the one-row layout at 800 px.

…gin and Preferences (#1150)

The autocommit switch, the statement timeout dropdown and the settings button
are one Session menu in the SQL toolbar, with the same values and handlers.
Begin transaction is in the menu too, and stays inline while no transaction is
open.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets ux User experience, keyboard shortcuts and interactions P2 Medium priority / Parity & Refactoring labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 11.72 ms 13.63 ms +16.3% ⚠️
p90 27.51 ms 23.16 ms -15.8%
p99 48.72 ms 49.42 ms +1.4%
stutters 322.00 280.00 -13.0%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 13.85 ms 14.59 ms +5.3% ⚠️
p90 17.07 ms 20.69 ms +21.2% ⚠️
p99 36.68 ms 45.16 ms +23.1% ⚠️
stutters 332.00 324.00 -2.4%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 7ed7b65 into dev Oct 9, 2026
14 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1150-session-menu branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets ux User experience, keyboard shortcuts and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant