Skip to content

feat(explain): a click on a plan node shows every field the driver reported (#1164) - #1230

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
feat/1164-plan-node-details
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
feat/1164-plan-node-details

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1164

What was wrong

The plan tree showed each node's operation, relation, rows and cost bar. The other fields the driver reported (startup cost, filters, index names and so on) were parsed into PlanNode.details but not shown, which the issue asks for in the details panel.

Changes

  • A click on a node selects it and shows a panel below the tree with its operation, relation, estimated and actual rows, cost, own cost and every reported field. A second click closes the panel.
  • The selected node has a stronger outline; the most expensive node keeps its highlight.
  • Widget test: a click shows the reported fields, the second click closes the panel.

Not in this PR

  • EXPLAIN ANALYZE with buffers, which the issue asks for behind an explicit action.
  • The acceptance check of a three-table join on a real database.

Not verified locally

Tests were not run locally, per the project rule.

…ported (#1164)

The plan tree showed operation, relation, rows and a cost bar; the other fields
the driver reported were parsed but not shown. A click on a node now opens a
panel with all of them; a second click closes it.
@github-actions github-actions Bot added enhancement New feature or request editor Code/SQL editor ui User interface components and widgets P3 Low priority / Polish & Enhancements labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 16.71 ms 16.91 ms +1.2%
p90 21.42 ms 26.05 ms +21.6% ⚠️
p99 54.25 ms 51.62 ms -4.8%
stutters 295.00 297.00 +0.7%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 976c23e into dev Oct 9, 2026
14 checks passed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 7.33 ms 7.23 ms -1.4%
p90 15.69 ms 16.16 ms +3.0%
p99 31.81 ms 35.95 ms +13.0% ⚠️
stutters 336.00 333.00 -0.9%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editor Code/SQL editor enhancement New feature or request P3 Low priority / Polish & Enhancements ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant