Repository navigation
fix(erd): interface review polish (notes, keys, views menu, grouping hint, marks) - #1301
Merged
Merged
Conversation
…iews menu, grouping hint, marked cards - A note without a colour is a slightly darker sheet with a shadow, on screen and in the exports, not the canvas colour with a hairline. - Touching a note, its resize handle or a group title gives the keyboard back to the canvas, so Esc, zoom and search keys work. - Every row of the views menu has a mark, so the labels line up; long view names are cut in the menu and the toolbar. - A card's New group... entry says that Shift+click marks more tables. - A marked card gets a ring outside it instead of a thicker border, so its content keeps the width it was measured for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items 5–9 of the ER diagram interface review (1, 2, 4 were #1299, 3 was #1300).
Tests:
test/features/erd/erd_ui_review_polish_test.dart— note fill and shadow; Ctrl+0 works after tapping a note with the focus on a widget outside the diagram; the long view name; the hint; the marked card's border width and ring.