Repository navigation
fix(errors): a missing column is not reported as a missing table (#1310) - #1324
Merged
Merged
Conversation
PostgreSQL words a missing INSERT/UPDATE column as column "x" of relation "t" does not exist; the relation pattern matched it and the user read Table "t" does not exist for a table that exists. Missing columns (PostgreSQL, MySQL, SQLite) are their own error, checked before the table patterns.
github-actions
Bot
added
bug
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1310
Problem:
mapDatabaseErrormappedrelation "([^"]+)" does not existto Table "t" does not exist. Check the table name and schema. PostgreSQL's message for a missing column in an INSERT / UPDATE iscolumn "x" of relation "t" does not exist, which contains that text, so the user was told the table was missing when only the column was.Fix: new
ColumnNotFoundException(column and table names);_columnMatchis checked before the table patterns and coverscolumn "x" of relation "t",column "x" does not exist(PostgreSQL),Unknown column 'x'(MySQL) andno such column: x(SQLite). Message: Column "x" does not exist in "t", hint: check the name or refresh the object tree.Tests: the INSERT form is a column error with both names and not a table error; the three engines' wordings without a table;
relation "orders" does not existis still a missing table.