Skip to content

fix(ssh): close zombie local port forwarder on SSH keep-alive ping failures - #1380

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1374-close-zombie-ssh-port-forwarder
Oct 10, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1374-close-zombie-ssh-port-forwarder

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1374

Summary

  • Tracks consecutive keep-alive ping failures (max 2) in SshTunnelManager's keepAliveTimer.
  • Proactively cleans up zombie sessions by closing the local ServerSocket and SSHClient and evicting the session from the pool map.
  • Ensures subsequent connection requests to the pool key establish a clean new SSH tunnel rather than reusing a dead forwarder.
  • Added unit tests covering consecutive ping failures, eviction/listener cleanup, and transient single-failure recovery.

@github-actions github-actions Bot added bug Something isn't working stability Theme parser epic label: stability core Core library logic and services connections Database connections, URI parsing, pools P2 Medium priority / Parity & Refactoring labels Oct 10, 2026
Fixes Code Analysis failure (unnecessary_non_null_assertion).
@ZhuchkaTriplesix
ZhuchkaTriplesix force-pushed the issue/1374-close-zombie-ssh-port-forwarder branch from 56bc431 to f974d79 Compare October 10, 2026 16:34
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 667b5fd into dev Oct 10, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1374-close-zombie-ssh-port-forwarder branch October 11, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working connections Database connections, URI parsing, pools core Core library logic and services P2 Medium priority / Parity & Refactoring stability Theme parser epic label: stability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant