Repository navigation
perf(ui): eliminate speculative layout overhead from IntrinsicWidth in QueryaTabStrip - #1428
Merged
ZhuchkaTriplesix merged 1 commit intoOct 11, 2026
Merged
Conversation
2 tasks
ZhuchkaTriplesix
deleted the
issue/1342-querya-tab-strip-intrinsic-width
branch
October 11, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1342
Summary of Changes
QueryaTabStrip, wrapped the scrollable tab strip in aLayoutBuildercheckingconstraints.hasBoundedWidth.Expanded/Flexible/SizedBoxacrossSqlQueryTabBar,GenericTableView,ResultsTab,ErdView),IntrinsicWidthis bypassed completely, eliminating redundant (N)$ speculative layout passes on every frame and rebuild.IntrinsicWidthto prevent unbounded flex scroll errors.test/shared/querya_tab_strip_test.dartverifying thatIntrinsicWidthis eliminated when parent width is bounded and retained as a fallback when unconstrained.