Repository navigation
perf(editor): eliminate quadratic line counting and substring allocations in SqlStatementSplitter (#1350) - #1453
Merged
Conversation
…ions in SqlStatementSplitter (#1350)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1350
Problem
SqlStatementSplitterpreviously incurred quadratic scans O(N*M) andsql.substring(i)string allocations with dynamic RegExp creation on every dollar sign.sql[i]allocated individual character string objects across millions of characters.Solution
sql[i]substring indexing tosql.codeUnitAt(i), eliminating all intermediate character allocations.SqlStatementSplitter.spansAsyncwhich offloads statement splitting to a background isolate viacomputefor scripts exceeding 64 KB (defaultIsolateThreshold).GenericSqlWorkspace._runSpansto async, leveragingspansAsyncto protect UI responsiveness during script execution.spansAsync(both sync below threshold and background isolate above threshold).