Repository navigation
refactor(ui): finish the control scale and button family leftovers - #1454
Merged
Merged
Conversation
- QueryaIconButton / QueryaToolbarButton take only a QueryaControlSize; the legacy QueryaIconButtonDensity enum and its 23 call sites are gone. - QueryaActionButton is removed: its 15 call sites use QueryaButton.secondary (destructive tone instead of isDestructive). - QueryaButtonGroup: segmented related actions as one outlined control, equal height, 1 px dividers. Refs #1333 #1334 #1335
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the remaining acceptance gaps of #1333, #1334 and #1335 after the migration PRs.
QueryaIconButton/QueryaToolbarButton: onlysize: QueryaControlSize; the legacyQueryaIconButtonDensityenum is removed and its 23 call sites inlib/useQueryaControlSize.sm/md.QueryaActionButtonis removed (it existed to let the migration go file by file, which is done): 15 call sites useQueryaButton.secondary, the destructive one viatone: QueryaButtonTone.destructive.QueryaButtonGroup(+QueryaButtonGroupItem): related actions that are not tabs as one outlined control with equal height and 1 px dividers, as inQueryaSplitButton; exported fromwidgets.dart, documented indocs/ui-kit.md.querya_button_group_test.dart; icon button and token tests usesize; the wrapper's test is deleted with the wrapper.Refs #1331