Repository navigation
fix(ui): QueryaTabStrip draws its focus ring only for keyboard focus - #1455
Merged
Merged
Conversation
A tab takes focus on click so arrow keys work, but the 2 px ring now appears only after a key is pressed, as for QueryaButton. Refs #1438
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1438.
A tab requests focus when clicked (so Left / Right / Home / End work), and the ring was drawn on every focus. The strip now remembers that the focus came from a click and draws the ring only after a key is pressed, matching
QueryaButtonanddocs/ui-kit.md.Test: clicking a tab shows no ring; the next arrow key moves selection and shows the ring on the new tab.