Repository navigation
fix(ui): the new-connection wizard search is a QueryaSearchField - #1459
Merged
Merged
Conversation
Replaces the hand-built box (magnifier outside the field and a second border) with QueryaSearchField at lg, with live filtering kept, and sets the category and database-type dropdowns to lg explicitly. Refs #1442
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1442.
The Select your database step drew its own search box (magnifier outside the field and a second border). It now uses
QueryaSearchFieldatlglike the sidebar and Preferences;debounceDuration: Duration.zerokeeps the filtering live and the selection reset when the chosen type no longer matches. The category and database-type dropdowns areQueryaDropdownand now saysize: lgexplicitly instead of relying on the default.No new test: the wizard is covered by the e2e connection-form test, which does not touch the search box.