Repository navigation
fix(ui): dismiss-only dialogs use a ghost Close in QueryaDialogActions - #1460
Merged
Merged
Conversation
…yaDialogActions About, Driver manager and Preferences build their footer with QueryaDialogActions (one divider, lg, spacing 8). Close in the update dialog's up-to-date state and in the extension manager header is ghost instead of primary: a dismiss-only action is never the main one. Refs #1441
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1441.
The standard says Cancel / Close are
ghostand the one main action isprimaryordestructive. Dialogs whose only action is Close drew it asprimary(About, Driver manager, extension manager, update dialog when up to date) orsecondary(Preferences).QueryaDialogActions(divider,lg, spacing 8); Preferences keeps its hint throughleading.ghost.Not in this PR (stays open in #1441): moving the remaining hand-built form footers to
QueryaDialogActionsand a test over the dialog list.