Repository navigation
refactor(ui): app toast on our own overlay, off shadcn - #1466
Merged
Merged
Conversation
github-actions
Bot
added
epic
…ntext The toast ended on a ticker, so pumpAndSettle ran its whole 5 s; it now plays only the entry on the controller and ends on a timer, as the old shadcn toast did. showAppToast also finds the overlay through the root navigator when the context is the navigator itself, and does nothing when there is none.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of #1465; the last kit widget of #1365 except the
widgets.dartbarrel.showAppToastno longer usesshadcn.showToast/Alert/GhostButton:QueryaMotion.standard, no motion under reduced motion (the old one-microsecond workaround for shadcn's removal callback is gone);showDurationor through aQueryaIconButton; the card hasliveRegionsemantics;void: no caller used the shadcn overlay it returned.app_toast.dartleaves the allow-list ofshared_does_not_import_shadcn_test.dart; only thewidgets.dartbarrel is left in it.Tests: shows and closes itself, close button, stacking, reduced motion.