Repository navigation
refactor(ui): private and raw Material buttons leave lib, button guards land - #1476
Merged
Merged
Conversation
_ActionButton (databases, collections), _SmallActionButton, _TreeIconButton and the staging toolbar's _ToolbarButton are QueryaButton / QueryaIconButton with a tooltip; five hand-drawn button classes less. Refs #1445
…ib, guards land 14 Material IconButtons (password eyes, dismiss, close, delete, sidebar toggle, search clear), the value panel's TextButton / ElevatedButton and literal tooltip delays use the kit. test/guards/button_standard_guards_test.dart forbids shadcn buttons, raw Material buttons, *Button classes outside the kit (two allowed) and literal tooltip delays. Refs #1445 #1339
github-actions
Bot
added
epic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1445 and #1339 (the epic #1331 tail).
Migrated
QueryaButton.secondary, destructive tone), the documents row actions and tree icon buttons (QueryaIconButtonwith tooltips), and the staging toolbar's Add Row / Delete Row (QueryaButton.ghost, compact).IconButtons: the password eyes (Redis form, auth section), the Dismiss of the test-connection banner in five forms, the Preferences and welcome tour close, the Redis delete icons, the title bar sidebar toggle and the search field's clear button.TextButton(Format, Minify) andElevatedButton(Update Cell Value) areQueryaButton.ghost/.primary.kQueryaTooltipWaitinstead of a 400 ms literal.Guards (
test/guards/button_standard_guards_test.dart): no shadcn button types, no raw Material buttons, no*Buttonclass outside the kit (allow-list:ThemePickerButton,TableEditModeButton), no literal tooltip delay.docs/ui-kit.mdguard table updated.Look to check: Mongo View is no longer green and Del is a secondary button with a destructive tone; the row action icons and tree icons lose their custom colours (the kit's ghost icon button); the Redis delete icons are destructive-tinted on hover.
Still open in #1445:
ThemePickerButton,TableEditModeButton, one password-field widget, and about 60InkWells used as rows (not buttons, probably out of scope), plus theBorderRadius.circular(n)literals.