fix(redis): loop SCAN until keys found or cursor reaches zero to prevent empty result lockup - #926
Merged
Merged
Conversation
…ent empty result lockup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
RedisKeysView._scanBatch(),SCAN cursor MATCH <pattern> COUNT 100was previously executed only once per batch. When scanning large keyspaces with a filter pattern, Redis can return 0 matching keys alongside a non-zero cursor. Previously, when 0 keys were returned on initial load,_keys.isEmptycaused the view to render the "No keys found" placeholder and completely hid theListView, hiding the "Load more" button and permanently locking the user out of the keyspace.Changes
RedisKeysView._scanBatch(), loopscancalls until at least some keys are discovered, cursor reaches0, or a safety iteration limit is reached.RedisKeysView.build(), if_keys.isEmptybut_hasMore == true(cursor > 0), display a visible "Continue scanning" action in the empty state instead of permanently locking the UI.test/features/redis/redis_keys_view_test.dartverifying empty-first-batch continuation and the "Continue scanning" flow.Closes #920