Skip to content

fix(mongodb): guard document editor Refresh against unsaved JSON edits #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Sep 24, 2026
Merged

fix(mongodb): guard document editor Refresh against unsaved JSON edits #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/features/mongodb/mongo_document_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,21 @@ class _MongoDocumentEditorState extends material.State<MongoDocumentEditor> {
void didUpdateWidget(covariant MongoDocumentEditor oldWidget) {
super.didUpdateWidget(oldWidget);
if (oldWidget.refreshToken != widget.refreshToken) {
_reloadFromServer();
material.WidgetsBinding.instance.addPostFrameCallback((_) {
if (mounted) unawaited(_reloadFromServer());
});
}
}

/// Fetches the latest document from the server (toolbar Refresh).
Future<void> _reloadFromServer() async {
final id = widget.document['_id'];
if (id == null) return;
if (_dirty) {
if (!await confirmDiscardUnsavedWorkIfNeeded(context)) return;
if (!mounted) return;
setState(() => _dirty = false);
}
setState(() {
_error = null;
_success = null;
Expand Down
90 changes: 90 additions & 0 deletions test/features/mongodb/mongo_document_editor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,94 @@ void main() {
);
expect(UnsavedWorkRegistry.instance.hasUnsaved, isFalse);
});

testWidgets(
'dirty Refresh Cancel keeps edits; Discard reloads from server',
(tester) async {
await tester.binding.setSurfaceSize(const material.Size(800, 700));

await tester.pumpWidget(
queryaThemeTestShell(
child: material.SizedBox(
width: 800,
height: 700,
child: MongoDocumentEditor(
connection: connection,
database: 'db',
collection: 'items',
document: const {'_id': 'abc', 'a': 1},
refreshToken: 0,
),
),
),
);
await tester.pumpAndSettle();
await pumpSyntaxHighlightDebounce(tester);

await tester.enterText(
find.byType(material.EditableText),
'{"_id":"abc","a":999}',
);
await tester.pump();
expect(UnsavedWorkRegistry.instance.hasUnsaved, isTrue);

// Bump refreshToken (simulate breadcrumb toolbar Refresh)
await tester.pumpWidget(
queryaThemeTestShell(
child: material.SizedBox(
width: 800,
height: 700,
child: MongoDocumentEditor(
connection: connection,
database: 'db',
collection: 'items',
document: const {'_id': 'abc', 'a': 1},
refreshToken: 1,
),
),
),
);
await tester.pumpAndSettle();

// Dialog must appear
expect(find.text('Unsaved changes'), findsOneWidget);

// Cancel must keep edits
await tester.tap(find.text('Cancel'));
await tester.pumpAndSettle();

final editable = tester.widget<material.EditableText>(
find.byType(material.EditableText),
);
expect(editable.controller.text, contains('999'));
expect(UnsavedWorkRegistry.instance.hasUnsaved, isTrue);

// Bump refreshToken again
await tester.pumpWidget(
queryaThemeTestShell(
child: material.SizedBox(
width: 800,
height: 700,
child: MongoDocumentEditor(
connection: connection,
database: 'db',
collection: 'items',
document: const {'_id': 'abc', 'a': 1},
refreshToken: 2,
),
),
),
);
await tester.pumpAndSettle();

expect(find.text('Unsaved changes'), findsOneWidget);
await tester.tap(find.text('Discard'));
await tester.pumpAndSettle();

expect(UnsavedWorkRegistry.instance.hasUnsaved, isFalse);

await tester.pumpWidget(
queryaThemeTestShell(child: const material.SizedBox()),
);
});
}
Loading