Skip to content

fix(extensions): require primary key and guard dirty edits in ExtensionTableView #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Sep 24, 2026
+313 −71
Merged

fix(extensions): require primary key and guard dirty edits in ExtensionTableView #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions lib/core/extensions/extension_driver_session.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,21 +445,18 @@ class ExtensionDriverSession {
required String tableName,
}) async {
final bridge = await ensureConnected(row);
try {
final result = await bridge.sendRequest('db.getTableSchema', {
'connectionId': row.id,
'database': database,
if (schema != null && schema.isNotEmpty) 'schema': schema,
'tableName': tableName,
});
if (result is Map) {
return TableSchemaMeta.fromJson(Map<String, dynamic>.from(result));
}
return TableSchemaMeta(tableName: tableName, schema: schema);
} catch (e) {
debugPrint('ExtensionDriverSession getTableSchema fallback ($e)');
return TableSchemaMeta(tableName: tableName, schema: schema);
final result = await bridge.sendRequest('db.getTableSchema', {
'connectionId': row.id,
'database': database,
if (schema != null && schema.isNotEmpty) 'schema': schema,
'tableName': tableName,
});
if (result is Map) {
return TableSchemaMeta.fromJson(Map<String, dynamic>.from(result));
}
throw StateError(
'Driver db.getTableSchema returned unexpected payload: $result',
);
}

/// Executes batch data mutations (insert, update, delete) via `db.mutate`.
Expand Down
224 changes: 167 additions & 57 deletions lib/features/extensions/extension_table_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {

ExtensionDriverCapabilities? _capabilities;
DataGridStagingBuffer? _stagingBuffer;
bool _schemaLoaded = false;
Object? _schemaError;
List<String> _primaryKeys = const [];
bool _isSaving = false;

bool _restartingDriver = false;
Expand Down Expand Up @@ -80,6 +83,12 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {

Future<void> _restartDriver() async {
if (_restartingDriver) return;
if (!await _confirmDiscardIfNeeded()) return;
if (!mounted) return;
_stagingBuffer?.dispose();
_stagingBuffer = null;
_schemaLoaded = false;
_schemaError = null;
setState(() {
_restartingDriver = true;
});
Expand Down Expand Up @@ -122,13 +131,19 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
if (oldWidget.connectionRow.id != widget.connectionRow.id ||
oldWidget.database != widget.database ||
oldWidget.tableName != widget.tableName) {
_offset = 0;
_totalRows = null;
_filterController.clear();
_filterActive = false;
_stagingBuffer?.dispose();
_stagingBuffer = null;
unawaited(_loadPage(refreshCount: true));
unawaited(() async {
if (!await _confirmDiscardIfNeeded()) return;
if (!mounted) return;
_stagingBuffer?.dispose();
_stagingBuffer = null;
_schemaLoaded = false;
_schemaError = null;
_offset = 0;
_totalRows = null;
_filterController.clear();
_filterActive = false;
await _loadPage(refreshCount: true);
}());
}
}

Expand All @@ -140,16 +155,89 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
super.dispose();
}

String get _tableTitle => '${widget.database}.${widget.tableName}';

bool get _isDirty => _stagingBuffer?.isDirty == true;

Future<bool> _confirmDiscardIfNeeded() {
return confirmDiscardTableEditsIfDirty(
context: context,
buffer: _stagingBuffer,
tableTitle: _tableTitle,
);
}

/// Guards navigation with a discard confirmation and then runs [action]
/// before triggering a page load.
Future<void> _navigateAndLoad(void Function() action) async {
if (!await _confirmDiscardIfNeeded()) return;
if (!mounted) return;
_stagingBuffer?.dispose();
_stagingBuffer = null;
action();
unawaited(_loadPage(refreshCount: true));
}

Future<void> _onRefresh() async {
if (!await _confirmDiscardIfNeeded()) return;
if (!mounted) return;
_stagingBuffer?.dispose();
_stagingBuffer = null;
_schemaLoaded = false;
_schemaError = null;
await _loadPage(refreshCount: true);
}

Future<void> _ensureSchema() async {
if (_schemaLoaded) return;
if (widget.isView || _capabilities?.supportsMutations != true) {
_schemaLoaded = true;
_schemaError = null;
_primaryKeys = const [];
return;
}
final loaded = await loadTableViewSchema(
() => ExtensionDriverSession.instance.getTableSchema(
widget.connectionRow,
database: widget.database,
tableName: widget.tableName,
),
);
final schema = loaded.schema;
if (schema != null) {
_primaryKeys = List<String>.from(schema.primaryKeys);
_schemaError = null;
} else {
_primaryKeys = const [];
_schemaError = loaded.error;
}
_schemaLoaded = true;
}

void _updateStatusLine() {
final total = _totalRows;
final shownFrom = _rows.isEmpty ? 0 : _offset + 1;
final shownTo = _offset + _rows.length;
final String pag;
if (total == null) {
_statusLine = _loading
pag = _loading
? 'Loading data...'
: 'Showing $shownTo row(s) (Calculating count...).';
} else {
_statusLine = 'Rows $shownFrom–$shownTo of $total.';
pag = 'Rows $shownFrom–$shownTo of $total.';
}
final reason = tableViewEditDisabledReason(
isView: widget.isView,
customSqlActive: false,
hasPrimaryKey: _primaryKeys.isNotEmpty,
schemaLoaded: _schemaLoaded,
readOnly: _capabilities != null && !_capabilities!.supportsMutations,
schemaError: _schemaError,
);
if (reason != null) {
_statusLine = '$pag · $reason';
} else {
_statusLine = pag;
}
}

Expand Down Expand Up @@ -208,18 +296,26 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
'SELECT * FROM $_qualifiedName$_whereClause LIMIT ${widget.pageSize} OFFSET $_offset',
);

await _ensureSchema();

if (!mounted) return;
setState(() {
_columns = dataResult.columns;
_rows = dataResult.rows;
_loading = false;
_stagingBuffer?.dispose();
if (!widget.isView && (_capabilities?.supportsMutations == true)) {
_stagingBuffer =
DataGridStagingBuffer(columns: _columns, rows: _rows);
} else {
_stagingBuffer = null;
}
final editingEnabled = tableViewEditingEnabled(
isView: widget.isView,
customSqlActive: false,
hasPrimaryKey: _primaryKeys.isNotEmpty,
readOnly: _capabilities?.supportsMutations != true,
schemaError: _schemaError,
);
_stagingBuffer = replaceTableViewStagingBuffer(
previous: _stagingBuffer,
columns: _columns,
rows: _rows,
enabled: editingEnabled,
);
_updateStatusLine();
});

Expand All @@ -238,14 +334,22 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
final buffer = _stagingBuffer;
if (buffer == null || !buffer.isDirty) return;

final primaryKeys = _primaryKeys;
if (primaryKeys.isEmpty) {
if (mounted) {
showAppToast(
context: context,
message:
'Cannot save: no primary key is available for ${widget.tableName}. '
'Edits would match all rows.',
variant: AppToastVariant.error,
);
}
return;
}

setState(() => _isSaving = true);
try {
final schema = await ExtensionDriverSession.instance.getTableSchema(
widget.connectionRow,
database: widget.database,
tableName: widget.tableName,
);

final mutations = <Map<String, dynamic>>[];

// 1. Updates
Expand All @@ -255,16 +359,10 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
final origRow = buffer.originalRows[rowIndex];

final whereMap = <String, dynamic>{};
if (schema.primaryKeys.isNotEmpty) {
for (final pk in schema.primaryKeys) {
final idx = _columns.indexOf(pk);
if (idx != -1 && idx < origRow.length) {
whereMap[pk] = origRow[idx];
}
}
} else {
for (var c = 0; c < _columns.length; c++) {
whereMap[_columns[c]] = c < origRow.length ? origRow[c] : null;
for (final pk in primaryKeys) {
final idx = _columns.indexOf(pk);
if (idx != -1 && idx < origRow.length) {
whereMap[pk] = origRow[idx];
}
}

Expand Down Expand Up @@ -304,16 +402,10 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
for (final rowIndex in buffer.deletedRowIndices) {
final origRow = buffer.originalRows[rowIndex];
final whereMap = <String, dynamic>{};
if (schema.primaryKeys.isNotEmpty) {
for (final pk in schema.primaryKeys) {
final idx = _columns.indexOf(pk);
if (idx != -1 && idx < origRow.length) {
whereMap[pk] = origRow[idx];
}
}
} else {
for (var c = 0; c < _columns.length; c++) {
whereMap[_columns[c]] = c < origRow.length ? origRow[c] : null;
for (final pk in primaryKeys) {
final idx = _columns.indexOf(pk);
if (idx != -1 && idx < origRow.length) {
whereMap[pk] = origRow[idx];
}
}
mutations.add({
Expand All @@ -330,10 +422,17 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
mutations: mutations,
);
if (!mounted) return;
final count = res['affectedRows'] ?? mutations.length;
final affectedRows = res['affectedRows'];
if (affectedRows is! int) {
throw StateError(
'Save failed: driver did not return an affectedRows count.',
);
}
expectDmlMatchedRows(affectedRows);

showAppToast(
context: context,
message: 'Successfully applied $count mutation(s).',
message: 'Successfully applied $affectedRows mutation(s).',
variant: AppToastVariant.success,
);
unawaited(_loadPage(refreshCount: true));
Expand All @@ -351,16 +450,18 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
}

void _applyFilter() {
_offset = 0;
_totalRows = null;
unawaited(_loadPage(refreshCount: true));
unawaited(_navigateAndLoad(() {
_offset = 0;
_totalRows = null;
}));
}

void _clearFilter() {
_filterController.clear();
_offset = 0;
_totalRows = null;
unawaited(_loadPage(refreshCount: true));
unawaited(_navigateAndLoad(() {
_offset = 0;
_totalRows = null;
}));
}

Future<void> _openDdlDialog() async {
Expand Down Expand Up @@ -437,24 +538,27 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
}
}

bool get _canGoBack => _offset > 0;
bool get _canGoBack => _offset > 0 && !_isDirty;

bool get _canGoForward {
if (_isDirty) return false;
final total = _totalRows;
if (total == null) return _rows.length >= widget.pageSize;
return _offset + widget.pageSize < total;
}

void _previousPage() {
if (!_canGoBack || _loading) return;
_offset = (_offset - widget.pageSize).clamp(0, 1 << 30);
unawaited(_loadPage());
unawaited(_navigateAndLoad(() {
_offset = (_offset - widget.pageSize).clamp(0, 1 << 30);
}));
}

void _nextPage() {
if (!_canGoForward || _loading) return;
_offset += widget.pageSize;
unawaited(_loadPage());
unawaited(_navigateAndLoad(() {
_offset += widget.pageSize;
}));
}

@override
Expand All @@ -473,7 +577,13 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
loading: _loading,
canGoPrevious: _canGoBack && !_loading,
canGoNext: _canGoForward && !_loading,
onNavigateHome: widget.onNavigateHome,
onNavigateHome: widget.onNavigateHome != null
? () => unawaited(() async {
if (!await _confirmDiscardIfNeeded()) return;
if (!mounted) return;
widget.onNavigateHome!();
}())
: null,
filterActive: _filterActive || _filterController.text.isNotEmpty,
filterText: _filterController.text,
onToggleFilter: () {
Expand All @@ -484,7 +594,7 @@ class _ExtensionTableViewState extends material.State<ExtensionTableView> {
onOpenDdl: _openDdlDialog,
onGoPrevious: _previousPage,
onGoNext: _nextPage,
onRefresh: () => _loadPage(refreshCount: true),
onRefresh: () => unawaited(_onRefresh()),
onRestartDriver: () => unawaited(_restartDriver()),
isRestarting: _restartingDriver,
onCopyFormat: (format) {
Expand Down
Loading
Loading