fix(sql): track query text modifications in SqlQueryTabSession to prevent unsaved data loss on tab/app close - #936
Merged
Conversation
…vent unsaved data loss on tab/app close (Closes #910)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #910
Summary of Changes:
_savedSqlandisModifiedinSqlQueryTabSessionto detect when SQL text has been edited from its disk-backed or initial state.isDirtyreturn true ifstagingBufferis dirty, if an unsaved draft tab has query text, or if a disk-backed tab has modified text.markSaved({String? newFilePath})method and call it on file open and file save across PostgreSQL, MySQL, SQLite, and Extension SQL workspaces.session.isDirtyon tab close and warn the user with a tailored message if uncommitted query text or staging data exists.UnsavedWorkRegistryautomatically queriessession.isDirty, preventing application exit while draft queries or edits exist.test/features/workspace/multi_tab_sql_workspace_test.dart.